Skip to content

fix: ensure #if blocks correctly guard against nullable prop values #16140

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
wants to merge 12 commits into
base: main
Choose a base branch
from
Draft

fix: ensure #if blocks correctly guard against nullable prop values #16140

wants to merge 12 commits into from

Conversation

rChaoz
Copy link
Contributor

@rChaoz rChaoz commented Jun 12, 2025 •
edited
Loading

Closes #16019, closes #16127

See #16019 for details.

On the failing test (runtime-legacy/binding-this-legacy-component-api): this one fails on main as well when using spread props, it fails on this PR because the logic that previously applied only on spread props logic now always applies. The $$events prop needs to exist somewhere even when using the spread props proxy.

Also, should investigate why #16019 (comment) isn't fixed

Before submitting the PR, please make sure you do the following

  • It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs
  • Prefix your PR title with feat:, fix:, chore:, or docs:.
  • This message body should clearly illustrate what problems it solves.
  • Ideally, include a test that fails without this PR but passes with it.
  • If this PR changes code within packages/svelte/src, add a changeset (npx changeset).

Tests and linting

  • Run the tests with pnpm test and lint the project with pnpm lint

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Jun 12, 2025 •
edited
Loading

⚠️ No Changeset found

Latest commit: e2290b5

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@github-actions GitHub Actions
Copy link
Contributor

Playground

pnpm add https://pkg.pr.new/svelte@16140

@rChaoz rChaoz mentioned this pull request Jun 12, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Bad state in effect teardowns ; non-nullable props are sometimes null Transitions may break dependencies when they change during transition
1 participant
@rChaoz